I've been in Japan for 7 years, and I am still delighted when people compliment me on my Japanese with 上手. So I agree with you, I cannot understand why foreigners feel it is an insult.